Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flight path preview when selecting images #1530

Merged
merged 15 commits into from
Jul 29, 2024
Merged

Add flight path preview when selecting images #1530

merged 15 commits into from
Jul 29, 2024

Conversation

pierotofy
Copy link
Member

Adds a plot of the flight path of the selected images (when GPS information is available). This is useful because it provides a sanity check on the selected images.

TODO:

  • Handle multiple image selects / drops
  • Add ability to specify a crop boundary directly from the map, instead of the tedious process of using geojson.io to specify a crop boundary via the task options.
  • (optional) I'm not sure I'm committed to do this right away, but could be neat to have the ability to remove images interactively, to remove mistakenly selected images.
  • Gracefully handle dataset with no georeferencing
  • Test very large datasets (e.g. more than 5000 images), exifr promises a ~2 seconds processing time, but I would test to see if it crashes...

@pierotofy
Copy link
Member Author

image

@pierotofy pierotofy marked this pull request as draft July 23, 2024 21:48
@pierotofy
Copy link
Member Author

Closes #1017

@Saijin-Naib
Copy link
Contributor

Love it!

Is a tabular list also possible alongside the map?

@pierotofy
Copy link
Member Author

What would be the use case?

@Saijin-Naib
Copy link
Contributor

An easier (potentially) way to verify image geolocation and status, especially with mixed geoloc and non-geoloc data, without map view encompassing half the globe or worse to fit the preview extent.

Also, thinking forward, might work for manual fixes/overrides to write out as geo.txt direct from this QA/QC step

@pierotofy
Copy link
Member Author

I could add buttons to export the data to GeoJSON / CSV. Could that work?

@Saijin-Naib
Copy link
Contributor

I think that covers some other excellent use-cases and simplifies other needed tools in the toolbox, so that is really cool for sure!

@pierotofy
Copy link
Member Author

Final implementation:
image

@pierotofy pierotofy marked this pull request as ready for review July 29, 2024 19:04
@pierotofy pierotofy merged commit 4bc22d3 into OpenDroneMap:master Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierotofy @Saijin-Naib